Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for hdf51122 fixed #119

Merged
merged 7 commits into from
Aug 14, 2022

Conversation

duncanmmacleod
Copy link
Contributor

@duncanmmacleod duncanmmacleod commented Aug 14, 2022

This PR augments #118 with the following fixes

Closes #115
Closes #118

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@duncanmmacleod duncanmmacleod marked this pull request as draft August 14, 2022 10:05
hmaarrfk and others added 2 commits August 14, 2022 11:46
@duncanmmacleod duncanmmacleod changed the title Draft: Attempt to fix HDF51122 migration Rebuild for hdf51122 fixed Aug 14, 2022
@duncanmmacleod duncanmmacleod marked this pull request as ready for review August 14, 2022 11:07
@duncanmmacleod
Copy link
Contributor Author

@conda-forge/h5py, this is ready for review, I think (cc @hmaarrfk).

@hmaarrfk
Copy link
Contributor

I'm not sure why cross compiling isn't working for arch and ppc64le. It should in theory work.

Travis is quite slow (mostly due to our limited access to it) so for these large build matrices, maybe it is good to do them on azure.

Copy link
Contributor

@hmaarrfk hmaarrfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@duncanmmacleod
Copy link
Contributor Author

I'm not sure why cross compiling isn't working for arch and ppc64le. It should in theory work.

I think this is because of the use of ctypes.CDLL(...) in setup_configure.py. This should be fixed by fcbb1ff, so bb08b91 could probably be harmlessly reverted if required.

@duncanmmacleod
Copy link
Contributor Author

Travis is quite slow (mostly due to our limited access to it) so for these large build matrices, maybe it is good to do them on azure.

From the tiny dataset that this PR represents, the travis-ci build matrix completes faster than the azure build matrix. The linux-ppc64le builds are the slowest, but are still faster than the win-64 builds run on Azure.

I appreciate that this is highly dependent on the total job queue on travis-ci, and UK morning/early-afternoon on a Sunday is probably the best time to attempt a large parallel matrix, but even if it is slower in general I prefer simplicity of configuration (using the 'default' provider in conda-forge.yml) over speed.

@hmaarrfk
Copy link
Contributor

Thank you for the thorough discussion, I think that this is a fine PR and should be merged. I'll let it sit here until a maintainer sees it.

@hmaarrfk hmaarrfk merged commit df10167 into conda-forge:main Aug 14, 2022
@hmaarrfk
Copy link
Contributor

Lets move on. The discussion was quite clear that the intention was to use the previous as a crutch, while a real fix is found.

Thanks for following through.

@duncanmmacleod duncanmmacleod deleted the rebuild-hdf51122-fix branch August 14, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

h5py 3.7.0 ARM not building
4 participants